Re: pgsql: Use pg_pread() and pg_pwrite() for data files and WAL. - Mailing list pgsql-committers

On Wed, Nov 7, 2018 at 11:32 AM Andrew Dunstan
<andrew.dunstan@2ndquadrant.com> wrote:
> On 11/6/18 4:01 PM, Thomas Munro wrote:
> > Use pg_pread() and pg_pwrite() for data files and WAL.
> >
> > Cut down on system calls by doing random I/O using offset-based OS
> > routines where available.  Remove the code for tracking the 'virtual'
> > seek position.  The only reason left to call FileSeek() was to get
> > the file's size, so provide a new function FileSize() instead.
>
> Getting this warning (gcc 8.2.1 Fedora 29):
>
> Nov 06 17:18:55
> /home/bf/bfr/root/HEAD/pgsql.build/../pgsql/src/backend/storage/file/fd.c:
> In function ‘FileSize’:
> Nov 06 17:18:55
> /home/bf/bfr/root/HEAD/pgsql.build/../pgsql/src/backend/storage/file/fd.c:2007:11:
> warning: variable ‘vfdP’ set but not used [-Wunused-but-set-variable]
> Nov 06 17:18:55   Vfd     *vfdP;
> Nov 06 17:18:55            ^~~~

Thanks, will fix.

--
Thomas Munro
http://www.enterprisedb.com