Phase 1: Document current behavior and set expectations
* Identify all ALTER TABLE actions involved in these inconsistencies. * Update the ALTER TABLE and CREATE TABLE documentation to clearly describe the current behavior for partitioned tables, and (where appropriate) the intended or ideal behavior. * Explicitly document the meaning of ONLY for partitioned tables, and note that some actions may behave differently, with details described in each action’s section.
I agree, we should modify alter to note the cascade and/or non-cascade scenarios and modify create to note the things that are (not) inherited. I'm fine with the "newly created" stuff being put into create table instead of touching 5.12.
I have removed all “newly created” from "alter table” doc, and added a paragraph in “create table” doc for those settings a new partition doesn’t inherit from the parent.
We should not be documenting "ideal behavior" - only actual behavior.
Absolutely.
We should indeed document that ONLY, if added to an alter command that would cascade to partitions, prevents that cascading. If added to a command that wouldn't cascade anyway it is usually accepted as just specifying the default behavior. There is no way to indicate explicitly that one wishes to cascade.
I went through all sub-commands and added ONLY back.
I still have my doubts whether changing long-standing behavior is going to happen. But that is also fairly immaterial since best practice is to proceed without even trying to predict the future and instead just deal with what is in front of us right now.
Let’s leave the discussion to separate threads.
Hi David, I have squashed all commits into one. As you have contributed a lot of work, I marked you as an author as well as a reviewer. Thanks a lot. Please take a look at v3 again.
