Request a Demo
Home   >   mailing lists

Avoid overflow (src/backend/utils/adt/formatting.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Avoid overflow (src/backend/utils/adt/formatting.c)
Date
Msg-id CAEudQAo-sk5jpjgPw=U=V7DOhSdQtU9APMRHkr4aV2SxtviqRw@mail.gmail.com
Whole thread Raw
Responses Re: Avoid overflow (src/backend/utils/adt/formatting.c)
List pgsql-hackers
Tree view
Hi.

Per Coverity.

Coverity raised the follow report:

CID 1642824: (#1 of 1): Overflowed constant (INTEGER_OVERFLOW)
37. overflow_const: Expression pattern_len - 1ULL, where pattern_len is known to be equal to 0, underflows the type of pattern_len - 1ULL, which is type unsigned long long.

This is because the function *pg_mbstrlen* can return zero.
And the comment is clear, *just in case there are MB chars*.

patch attached.

best regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Christian Ullrich
Date:
Subject: C nitpick about pgwin32_dispatch_queued_signals()
Next
From: Michael Banck
Date:
Subject: Re: Include extension path on pg_available_extensions