Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c)
Date
Msg-id CAEudQAoJ6_wZR_Ui+M4e9LHvcfo0Nnuhqghhrs068jSPdovA4w@mail.gmail.com
Whole thread Raw
In response to Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c)  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Fix a possible socket leak at Windows (src/backend/port/win32/socket.c)
List pgsql-hackers
Em seg., 15 de jan. de 2024 às 09:43, Daniel Gustafsson <daniel@yesql.se> escreveu:
> On 13 Jan 2024, at 22:38, Ranier Vilela <ranier.vf@gmail.com> wrote:

> In the pgwin32_socket function (src/backend/port/win32/socket.c), there is a possible socket leak if the socket cannot be made non-blocking.

I don't know Windows well enough to comment on the implications of not calling
closesocket here, but it definitely seems like a prudent thing to do
backpatched down to 12. Unless objections I'll do that.
Thanks for taking care of this.
Do you have plans or should I register for a commitfest?

Best regards,
Ranier Vilela

pgsql-hackers by date:

Previous
From: Matthias van de Meent
Date:
Subject: Re: cleanup patches for incremental backup
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: UUID v7