Postgres Pro
Downloads
Home   >   mailing lists

Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c) - Mailing list pgsql-hackers

From Ranier Vilela
Subject Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c)
Date
Msg-id CAEudQAoSA7saBF7RaoYbRjE+Zojojin0Qc9A4hebPKB8o1J+EQ@mail.gmail.com
Whole thread Raw
Responses Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c)
List pgsql-hackers
Tree view
Hi,

Per Coverity.

At function ExtendBufferedRelShared, has a always true test.
eb.rel was dereferenced one line above, so in
if (eb.rel) is always true.

I think it's worth removing the test, because Coverity raises dozens of alerts thinking eb.rel might be NULL.
Besides, one less test is one less branch.

regards,
Ranier Vilela
Attachment

pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: Avoid unused value (src/fe_utils/print.c)
Next
From: Amit Kapila
Date:
Subject: Re: Wrong syntax in feature description