Re: Simplify the logic a bit (src/bin/scripts/reindexdb.c) - Mailing list pgsql-hackers

On 2025-Feb-14, Ranier Vilela wrote:

> Attached is the prototype version v1.
> What do you think?

I think this is still a bit confused.  The new function's comment says
"prepare the list of tables to ..." but what it really receives is a
list of _indexes_ (as evidenced by the fact that they're compared to
pg_index.indexrelid).  So on input the user_list is an index list, and
on output it has been changed into a list of tables, and the list of
indexes is the function's return value?  That seems quite weird.

  I
propose to change the API of this new function thus:

static void
get_parallel_tabidx_list(PGconn *conn,
                SimpleStringList *index_list,
                SimpleStringList *table_list,
                bool echo);

where index_list is inout and the table_list is just an output argument.

I would also remove the 'type' argument, because I don't see a need to
keep it.