Em sex., 3 de out. de 2025 às 09:13, Greg Burd <greg@burd.me> escreveu:
On Oct 3 2025, at 4:25 am, Daniel Gustafsson <daniel@yesql.se> wrote:
>> On 3 Oct 2025, at 01:36, David Rowley <dgrowleyml@gmail.com> wrote: >> >> On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson <daniel@yesql.se> wrote: >>> Another nitpick would be to remove the test for NULL in test_bms_make_singleton >>> since that is a STRICT function, making the test for NULL >>> superfluous code: >> >> I see test_random_operations() is also strict. Is it worth getting rid >> of the SQL NULL checks on the inputs there too? Aka, the attached. > > Indeed, but reading the code I wonder if STRICT was a mistake and the intention > was to allow NULL input?
Yes, it was an oversight after I re-worked the random function.
> That being said, the function is never called with > NULL so that's mostly academic thinking. +1 for removing the NULL > checks and simplifying the code.
I agree, and thank you both for the attention to detail and interest in this test suite.
With the patch attached, there are regression.
Is it intentional not to check the return of the function bms_is_member?
-- random operations SELECT test_random_operations(-1, 10000, 81920, 0) > 0 AS result; - result --------- - t -(1 row) - +ERROR: union missing member 63904 DROP EXTENSION test_bitmapset;
