> The function *ScanPgRelation* can return a invalid tuple. > It is necessary to check the function's return, > as is already done in other parts of the source.
Good find although I'm not certain if I agree with the patch.
We would be in serious trouble if RelationReloadNailed() could be called for a non-existing relation. Wouldn't Assert() be more appropriate?
IMO, I think no.
In all paths, this check is done, why would this be the only exception?