Re: Small refactoring around vacuum_open_relation - Mailing list pgsql-hackers

> On Thu, Jan 9, 2025 at 5:30 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 9 Jan 2025, at 11:45, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> > Dunno what others think, this seems useless churn to me.
>
> I agree, I don't see this providing enough value to warrant the changes.
>

I agree about most of the changes however

>
> > I found some more
> > static const struct
> > {
> > LOCKMODE hwlock;
> > int lockstatus;
> > int updstatus;
> > }
> >
> > tupleLockExtraInfo[MaxLockTupleMode + 1] =
> >
> > hwlock should be hwlockmode?

this one looks useful. Variable name hwlock indicates some kind of
lock (object) not a mode in which it should be locked. This is
especially so when the next variable is named lockstatus indicating
status of the lock.

--
Best Wishes,
Ashutosh Bapat