Re: pgsql: Build all Flex files standalone - Mailing list pgsql-committers

From John Naylor
Subject Re: pgsql: Build all Flex files standalone
Date
Msg-id CAFBsxsGVJ6pYVAPGFd4M0Bi=r3ocWJ5Lt5MEq+iwGWkRfb_w+g@mail.gmail.com
Whole thread Raw
In response to pgsql: Build all Flex files standalone  (John Naylor <john.naylor@postgresql.org>)
Responses Re: pgsql: Build all Flex files standalone
List pgsql-committers
The second failure is on drongo (MSVC):

"c:\\prog\\bf\\root\\HEAD\\pgsql.build\\pgsql.sln" (default target) (1) ->
"c:\\prog\\bf\\root\\HEAD\\pgsql.build\\isolationtester.vcxproj"
(default target) (13) ->
(Link target) ->
  specparse.obj : error LNK2019: unresolved external symbol spec_yylex
referenced in function spec_yyparse
[c:\\prog\\bf\\root\\HEAD\\pgsql.build\\isolationtester.vcxproj]
  specparse.obj : error LNK2019: unresolved external symbol
spec_yyerror referenced in function spec_yyparse
[c:\\prog\\bf\\root\\HEAD\\pgsql.build\\isolationtester.vcxproj]
  .\\Release\\isolationtester\\isolationtester.exe : fatal error
LNK1120: 2 unresolved externals
[c:\\prog\\bf\\root\\HEAD\\pgsql.build\\isolationtester.vcxproj]

For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe
something like the following is needed:

--- a/src/tools/msvc/Mkvcbuild.pm
+++ b/src/tools/msvc/Mkvcbuild.pm
@@ -362,6 +362,7 @@ sub mkvcbuild
        $isolation_tester->AddFile('src/test/isolation/specparse.y');
        $isolation_tester->AddFile('src/test/isolation/specscanner.l');
        $isolation_tester->AddFile('src/test/isolation/specparse.c');
+       $isolation_tester->AddFile('src/test/isolation/specscanner.c');
        $isolation_tester->AddIncludeDir('src/test/isolation');

-- 
John Naylor
EDB: http://www.enterprisedb.com



pgsql-committers by date:

Previous
From: John Naylor
Date:
Subject: Re: pgsql: Build all Flex files standalone
Next
From: John Naylor
Date:
Subject: pgsql: Fix MSVC linker error for specparse.obj