Postgres Pro
Downloads
Home   >   mailing lists

Re: Excessive number of replication slots for 12->14 logical replication - Mailing list pgsql-bugs

From Ajin Cherian
Subject Re: Excessive number of replication slots for 12->14 logical replication
Date
Msg-id CAFPTHDYRHkgaNqgkNH62-mo1-vb1w-aFfnzZMGpvUzedxqmggQ@mail.gmail.com
Whole thread Raw
In response to Re: Excessive number of replication slots for 12->14 logical replication  (Masahiko Sawada <sawada.mshk@gmail.com>)
List pgsql-bugs
Tree view 
On Fri, Aug 12, 2022 at 3:22 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> ISTM that the "This" in the first sentence in the second paragraph
> still indicates the cleanup of the origin tracking and table sync
> slot. How about not having the common comment for both like the patch
> I've attached? In addition to this change, I moved the code to drop
> the origin before stopping the streaming so that it can be close to
> the slot drop. But feel free to revert this change.
>

This looks fine to me.

regards,
Ajin Cherian
Fujitsu Australia

pgsql-bugs by date:

Previous
From: Masahiko Sawada
Date:
Subject: Re: Excessive number of replication slots for 12->14 logical replication
Next
From: PG Bug reporting form
Date:
Subject: BUG #17583: Server crashes on executing CROSS JOIN with very big number of tables