Re: Fix for issue RM1336 [pgadmin4] - Mailing list pgadmin-hackers
| From | Harshal Dhumal |
|---|---|
| Subject | Re: Fix for issue RM1336 [pgadmin4] |
| Date | |
| Msg-id | CAFiP3vyTB+ceHGxwXn_w8RBmDQn9SVC3i+1kXhv=CD8UWr3=Xg@mail.gmail.com Whole thread Raw |
| In response to | Re: Fix for issue RM1336 [pgadmin4] (Dave Page <dpage@pgadmin.org>) |
| Responses |
Re: Fix for issue RM1336 [pgadmin4]
|
| List | pgadmin-hackers |
Hi,
As per my offline discussion with Ashesh; He is suggesting not to use Function keys as shortcuts.
And regarding configurable key options, I suspect It is going to be time consuming task, please let me know if you want me to start working it. Or can we keep current shortcuts from my last patch?
On Thu, Jun 16, 2016 at 4:19 PM, Dave Page <dpage@pgadmin.org> wrote:
Hi
Hmm, I guess that's system dependent. What about Ctrl+F5? Or we bite
the bullet and make it configurable.
On Thu, Jun 16, 2016 at 11:47 AM, Harshal Dhumal<harshal.dhumal@enterprisedb.com> wrote:
> Hi Dave,
>
> Function keys won't work properly with browser as they already have
> predefined bindings.
>
> e.g.
>
> F5 for refresh (standard)
> F7 for Caret Browsing in firefox
>
>
> --
> Harshal Dhumal
> Software Engineer
>
> EnterpriseDB India: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> On Thu, Jun 16, 2016 at 4:10 PM, Harshal Dhumal
> <harshal.dhumal@enterprisedb.com> wrote:
>>
>> Hi Dave,
>>
>> Ok, I'll change shortcut keys
>>
>> New shortcuts would be:
>>
>> Execute --> F5
>> Explain --> F7
>> Explain analyze --> Shift+F7
>>
>>
>>
>> --
>> Harshal Dhumal
>> Software Engineer
>>
>> EnterpriseDB India: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>> On Thu, Jun 16, 2016 at 4:03 PM, Dave Page <dpage@pgadmin.org> wrote:
>>>
>>> Hi,
>>>
>>> Can we not make them compatible with pgAdmin 3? Ctrl + Shift + E is
>>> significantly less convenient than F5.
>>>
>>> On Thu, Jun 16, 2016 at 11:28 AM, Harshal Dhumal
>>> <harshal.dhumal@enterprisedb.com> wrote:
>>> > Hi,
>>> >
>>> > PAF patch for issue RM1336
>>> >
>>> > Changes: Added keyboard shortcuts (static/non configurable) to some
>>> > query
>>> > tool operations.
>>> >
>>> > Execute --> Ctrl + Shift + E
>>> > Explain --> Ctrl + Shift + X
>>> > Explain analyze --> Ctrl + Shift + A
>>> >
>>> > Note: Keyboard shortcuts do not work if focus is set on any disabled
>>> > button
>>> > inside query tool or out side the query tool.
>>> >
>>> >
>>> > --
>>> > Harshal Dhumal
>>> > Software Engineer
>>> >
>>> > EnterpriseDB India: http://www.enterprisedb.com
>>> > The Enterprise PostgreSQL Company
>>> >
>>> >
>>> > --
>>> > Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
>>> > To make changes to your subscription:
>>> > http://www.postgresql.org/mailpref/pgadmin-hackers
>>> >
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>
>>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgadmin-hackers by date: