Request a Demo
Home   >   mailing lists

Re: Broken example in PL/PgSQL documentation - Mailing list pgsql-docs

From Pavel Stehule
Subject Re: Broken example in PL/PgSQL documentation
Date
Msg-id CAFj8pRARV2uk=h8YO8AiW-P=HcqqvbQ2YxSWAb+r7QmGVXQ62A@mail.gmail.com
Whole thread Raw
In response to Re: Broken example in PL/PgSQL documentation  (Marti Raudsepp <marti@juffo.org>)
Responses Re: Broken example in PL/PgSQL documentation
List pgsql-docs
Tree view


2014-10-08 21:25 GMT+02:00 Marti Raudsepp <marti@juffo.org>:
On Thu, Sep 4, 2014 at 3:06 PM, Marko Tiikkaja <marko@joh.to> wrote:
> Just came across a broken example in the docs

+1. New version works. I would slightly prefer adding an alias to the table:

    RETURN QUERY SELECT s.quantity, s.quantity * s.price FROM sales AS s
                 WHERE s.itemno = p_itemno;

Other than that, there's not much to review here, marking as "Ready
for Committer"

This last patch is good. I it good fix of this problem - and usage of qualified identifiers is common and recommended solution.

It is really ready for commiter.

Regards

Pavel
 

Alternative patch attached, let the committer decide.

Regards,
Marti


--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs


pgsql-docs by date:

Previous
From: Marti Raudsepp
Date:
Subject: Re: Broken example in PL/PgSQL documentation
Next
From: Fujii Masao
Date:
Subject: Re: Broken example in PL/PgSQL documentation