Re: Re: proposal: schema variables - Mailing list pgsql-hackers

From Pavel Stehule
Subject Re: Re: proposal: schema variables
Date
Msg-id CAFj8pRDDizf70=U6H+=O22mqQcVXB40vzvb-bsw4qsegzYdSXg@mail.gmail.com
Whole thread Raw
In response to Re: Re: proposal: schema variables  (Álvaro Herrera <alvherre@alvh.no-ip.org>)
List pgsql-hackers
Hi

po 20. 1. 2025 v 8:56 odesílatel Álvaro Herrera <alvherre@alvh.no-ip.org> napsal:
On 2025-Jan-17, Bruce Momjian wrote:

> Is this really something we are considering applying, since it has been
> around for years?  I am unclear on that and we had better know if we are
> going to continue reviewing this.

The fact that the patch has been around for years doesn't automatically
mean it's a bad idea.

I have proposed that we discuss this patch at fosdem developer's meeting
next month, precisely to seek consensus on whether this patch is
something we want or not.  My view is that this is a feature that has
been requested by users for years, so IMO we want this or something
similar.

I wonder if the reason that committers stay away from it is that
reviewing it fully (and thus taking responsibility for it) seems such a
daunting task.  I might be wrong, but I think this may be the largest
patch since FTS.

This patch is huge, but I think it is not comparable with parallel processing support or with replication support.

It doesn't introduce new processes or new data structures or does important changes in planner, and I think so almost all code is very simple.

In early versions of this patch, there was a complex part to ensure validity of content in memory. But it was fully removed and replaced
just by comparing with create_lsn.

Regards

Pavel


--
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
Tom: There seems to be something broken here.
Teodor: I'm in sackcloth and ashes...  Fixed.
                               http://postgr.es/m/482D1632.8010507@sigaev.ru

pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Replace current implementations in crypt() and gen_salt() to OpenSSL
Next
From: Jim Jones
Date:
Subject: Re: XMLDocument (SQL/XML X030)