Re: [HACKERS] "create publication..all tables" ignore 'partition notsupported' error - Mailing list pgsql-hackers

From Kuntal Ghosh
Subject Re: [HACKERS] "create publication..all tables" ignore 'partition notsupported' error
Date
Msg-id CAGz5QCK30cVqZNBk1fUCVuXzcTsaiVy4VMniYXKmZs8DwJEUVQ@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] "create publication..all tables" ignore 'partition notsupported' error  (Masahiko Sawada <sawada.mshk@gmail.com>)
Responses Re: [HACKERS] "create publication..all tables" ignore 'partition notsupported' error
List pgsql-hackers
On Wed, May 31, 2017 at 12:58 AM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> I'd say we can fix this issue by just changing the query. Attached
> patch changes the query so that it can handle publication name
> correctly, the query gets complex, though.
>
In is_publishable_class function, there are four conditions to decide
whether this is a publishable class or not.

1. relkind == RELKIND_RELATION
2. IsCatalogClass()
3. relpersistence == 'p'
4. relid >= FirstNormalObjectId /* Skip tables created during initdb */

I think the modified query should have a check for the fourth condition as well.

Added to open items.

-- 
Thanks & Regards,
Kuntal Ghosh
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [HACKERS] [PATCH] quiet conversion warning in DatumGetFloat4
Next
From: Ashutosh Bapat
Date:
Subject: Re: [HACKERS] Effect of changing the value for PARALLEL_TUPLE_QUEUE_SIZE