On Wed, Jan 7, 2026 at 1:50 PM Peter Geoghegan <pg@bowt.ie> wrote:
> v6 focusses on simplifying the batch management code in
> heapam_batch_getnext_tid. Importantly, heapam_batch_getnext_tid no
> longer uses a loop to process items from the currently loaded batch/to
> load the next batch. The control flow in heapam_batch_getnext_tid is a
> lot simpler in general compared to v5.
The batch stopped applying again. Attached is v7.
Changes:
* Much improved read stream callback code, with comments that explain
exactly what's going on at each step.
* We once again support prefetching with index-only scans (for any
heap fetches that might be required).
We must cache visibility information at the level of whole batches for
this. Otherwise, the read stream have a different idea about which
heap pages are considered all visible from other code. The
corresponding code that actually reads heap tuples expects to be able
to get buffers from the read stream that precisely match what it
believes are required for any heap fetches. If they don't both agree
about visibility info, chaos ensues.
We avoid per-tuple visibility lookups in v7, preferring to do
everything (every VM lookup for every TID) up front for each batch.
This is simpler, and I suspect it's somewhat faster on average.
* Fixed several bugs involving scrollable cursors + index prefetching.
> I still haven't had time to produce an implementation of the "heap
> buffer locking minimization" optimization that's clean enough to
> present to the list.
Still haven't done this. Our new thinking on this is that it'd be best
to get prefetching in better shape before proceeding with the heap
buffer locking optimization.
--
Peter Geoghegan
