Postgres Pro
Downloads
Home   >   mailing lists

Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c) - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c)
Date
Msg-id CAH2-WzmsXA4EXk9SCBhLAjxJsw87SoZ0fs61C6Dt4SvgtbR+yg@mail.gmail.com
Whole thread Raw
In response to Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c)  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c)
List pgsql-hackers
Tree view 
On Thu, Aug 24, 2023 at 6:44 PM David Rowley <dgrowleyml@gmail.com> wrote:
> I agree with this. I think Ranier's patch is good and we should apply
> it and backpatch it.

FWIW I'm pretty sure that it's impossible to run into problems here in
practice -- the minheap is allocated by palloc(), and the high
watermark number of free pages is pretty small. Even still, I agree
with your conclusion. There is really no reason to not be consistent
here.

--
Peter Geoghegan

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Avoid a possible overflow (src/backend/utils/sort/logtape.c)
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: [PoC] pg_upgrade: allow to upgrade publisher node