Request a Demo
Home   >   mailing lists

Re: Adding skip scan (including MDAM style range skip scan) to nbtree - Mailing list pgsql-hackers

From Peter Geoghegan
Subject Re: Adding skip scan (including MDAM style range skip scan) to nbtree
Date
Msg-id CAH2-WznsZdjaSQL_CT2TpYoLmOE-k8-rHB27mJcdAg0+UnU+7A@mail.gmail.com
Whole thread Raw
In response to Re: Adding skip scan (including MDAM style range skip scan) to nbtree  (Peter Geoghegan <pg@bowt.ie>)
List pgsql-hackers
Tree view 
On Wed, Sep 10, 2025 at 12:45 PM Peter Geoghegan <pg@bowt.ie> wrote:
> I don't understand why it is that our not resetting the so->Skipscan
> flag within btrescan has any particular significance to Timescaledb,
> relative to all of the other fields that are supposed to be set by
> _bt_preprocess_keys.

I notice that the skipScan flag isn't initialized in the path where
there's no array keys at all on this rescan.

Does the attached patch (which moves back the initialization such that
the flag will always be initialized on rescan) fix the problem you're
seeing?

> What is the actual failure you see? Is it an
> assertion failure within _bt_readpage/_bt_checkkeys?

Still curious about this.

--
Peter Geoghegan
Attachment

pgsql-hackers by date:

Previous
From: Peter Geoghegan
Date:
Subject: Re: Adding skip scan (including MDAM style range skip scan) to nbtree
Next
From: Jeff Davis
Date:
Subject: Re: Incorrect logic in XLogNeedsFlush()