Re: Trivial fix for comment of function table_tuple_lock - Mailing list pgsql-hackers

On Mon, Sep 22, 2025 at 2:54 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
> Hi Fujii-san,
>
> Thank you very much for taking care of this patch.
>
> I just updated the patch, see attached v2. In v2, I removed "tid" from the comment of heap_lock_tuple(), and I found
acouple of more occurrences of "relation"=>"rel" in tableam.h. 

Thanks for updating the patch! LGTM.

While also checking the comments for table_tuple_delete() and
table_tuple_update(),
I noticed a few other issues. Wouldn’t it be better to fix these together?

* changingPart is listed as an output parameter for table_tuple_delete(),
    but it looks like an input.
* slot is listed as an input parameter for table_tuple_update(), but it seems
    to be an output.
* The comment for update_indexes in table_tuple_update() is mis-indented.
* Not an issue, but it might be clearer to add a blank line between the input
    and output parameter comments in table_tuple_delete() and
    table_tuple_update().

Regards,

--
Fujii Masao