Request a Demo
Home   >   mailing lists

Re: Trivial fix for comment of function table_tuple_lock - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Trivial fix for comment of function table_tuple_lock
Date
Msg-id CAHGQGwEkxYC_7A8RhWzAjiA2ApoGQ7MLoOALtkueChqc0=J=Sg@mail.gmail.com
Whole thread Raw
In response to Trivial fix for comment of function table_tuple_lock  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: Trivial fix for comment of function table_tuple_lock
List pgsql-hackers
Tree view 
On Thu, Sep 11, 2025 at 2:40 PM Chao Li <li.evan.chao@gmail.com> wrote:
>
> Hi Hackers,
>
> Just fixed an one-word error in comment. Please take a look.

Thanks for the patch! LGTM.

It looks like this happened because heapam_tuple_lock() and heap_lock_tuple()
use the argument relation instead of rel, and the comments for
table_lock_tuple() were probably copied from heap_lock_tuple(),
leaving relation in place by mistake.

By the way, I noticed another typo in the comments for heap_lock_tuple():
the input parameter description for tid ("TID of tuple to lock")
should be removed,
since that function doesn’t take tid. How about fixing both issues in
the same patch,
since there’s no need to commit them separately?

Regards,

--
Fujii Masao

pgsql-hackers by date:

Previous
From: Ashutosh Bapat
Date:
Subject: Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
Next
From: shveta malik
Date:
Subject: Re: Report bytes and transactions actually sent downtream