Re: issue with synchronized_standby_slots - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: issue with synchronized_standby_slots
Date
Msg-id CAHGQGwFztr_hHUHyKwc2xxoC8o7h9xv6bVsWbt9BCCxyb8sP-Q@mail.gmail.com
Whole thread Raw
In response to RE: issue with synchronized_standby_slots  ("Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>)
List pgsql-hackers
On Tue, Sep 9, 2025 at 2:39 PM Zhijie Hou (Fujitsu)
<houzj.fnst@fujitsu.com> wrote:
> I agree. For synchronized_standby_slots, I think it is acceptable to report only
> parsing errors, because slots could be dropped even after validating the slot
> existence during GUC loading. Additionally, we would report WARNINGs for
> non-existent slots during the wait function anyway (e.g., in
> StandbySlotsHaveCaughtup()).

+1, to also address the issue I reported upthread.

As I understand it, only the walsender and the slot sync worker actually
use synchronized_standby_slots. But in the current code, all processes check
for slot existence via the GUC check hook, which wastes cycles. The proposed
change would eliminate that overhead.

Regards,

--
Fujii Masao



pgsql-hackers by date:

Previous
From: Fujii Masao
Date:
Subject: Re: pg_restore --no-policies should not restore policies' comment
Next
From: Zsolt Parragi
Date:
Subject: Re: OAuth client code doesn't work with Google OAuth