Hi Shlok.
Here are some review comments for the patch v25-0001 (RESET).
I belatedly saw that you said this is a rebase *only*, so does not yet
address any of the earlier review comments [1]. Anyway, below are a
few more comments that I did not report previously.
======
Commit message
1.
This patch adds a new RESET clause to ALTER PUBLICATION which will reset
the publication to the default state which includes resetting the publication
parameters, setting ALL TABLES flag to false and dropping the relations and
schemas that are associated with the publication.
~
1a.
/which includes.../. This includes...
~
1b.
Needs to also mention about ALL SEQUENCES
======
src/backend/commands/publicationcmds.c
AlterPublicationReset:
2.
+ /* Set ALL TABLES flag to false */
+ if (pubform->puballsequences)
+ {
+ values[Anum_pg_publication_puballsequences - 1] =
BoolGetDatum(PUB_DEFAULT_ALL_SEQUENCES);
+ replaces[Anum_pg_publication_puballsequences - 1] = true;
+ }
The comment should say ALL SEQUENCES.
======
[1] my review of v24-0001
https://www.postgresql.org/message-id/CAHut%2BPvoOVo%3D_O-sG8wNaLRBPSD%2B6S%3D4PXOH2r%3DyKTxbpAbHkg%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia
