Request a Demo
Home   >   mailing lists

Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility. - Mailing list pgsql-hackers

From Peter Smith
Subject Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility.
Date
Msg-id CAHut+PtOs5ZewdpEnNQYNYXt08FvbqH_Q6yLnba_VjBe+KucoQ@mail.gmail.com
Whole thread Raw
In response to Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility.  (vignesh C <vignesh21@gmail.com>)
Responses Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility.
List pgsql-hackers
Tree view 
Hi Shubham,

Patch v12-0001 LGTM.

BTW, there is a precedent for passing the 'opt' arg but then only
using one member from it. See function wait_for_end_recovery in this
same file. So whether you decide to change the code per Shlok's review
[1], or decide not to change it -- either way is OK for me.

======
[1] https://www.postgresql.org/message-id/CANhcyEXQ1h%3DoSPFFziCZuU6far6a82DQafL0S85CyVRyEntA%2Bw%40mail.gmail.com

Kind Regards,
Peter Smith.
Fujitsu Australia

pgsql-hackers by date:

Previous
From: Kashif Zeeshan
Date:
Subject: Re: [PoC] Federated Authn/z with OAUTHBEARER
Next
From: Amul Sul
Date:
Subject: Re: Bug in detaching a partition with a foreign key.