Re: Pgoutput not capturing the generated columns - Mailing list pgsql-hackers

Hi Vignesh,

Here are my review comments for patch v48-0001.

======
src/backend/catalog/pg_publication.c

has_column_list_defined:

1.
+ if (HeapTupleIsValid(cftuple))
+ {
+ bool isnull = true;
+
+ /* Lookup the column list attribute. */
+ (void) SysCacheGetAttr(PUBLICATIONRELMAP, cftuple,
+    Anum_pg_publication_rel_prattrs,
+    &isnull);

AFAIK it is not necessary to assign a default value to 'isnull' here.
e.g. most of the other 100s of calls to SysCacheGetAttr elsewhere in
PostgreSQL source don't bother to do this.

//////////

I also checked the docs patch v48-0002. That now looks good to me.

======
Kind Regards,
Peter Smith.
Fujitsu Australia