Hi Shubham,
Here are my comments for v4-0001.
1.
- If <option>replication-slot-name</option> is not specified, the
+ If the <option>--replication-slot-name</option> is not specified, the
No. I already said before ([1] #2) that there is no such thing called
"--replication-slot-name". It should be called "--replication-slot"
~~~
2.
FYI your v4 changes are not using the text that I had suggested in
[1]. E.g. When the switch/option term is not included I felt it was
better to omit the word "the". Maybe you changed that deliberately, in
which case that is your choice, but TBH I suspect this may have been
unintentional.
IMO it should look like this.
/If the <option>--publication</option> is not specified/If
<option>--publication</option> is not specified/
/If the <option>--replication-slot-name</option> is not specified/If
<option>--replication-slot</option> is not specified/
/If the <option>--subscription</option> is not specified/If
<option>--subscription</option> is not specified/
======
[1] https://www.postgresql.org/message-id/CAHut%2BPs8Xq-e5XL%3DAejiX-pF0417Vc7tMrh%2BYuZjBt7ozjvPUA%40mail.gmail.com
Kind Regards,
Peter Smith.
Fujitsu Australia