Re: No Callbacks on FATAL - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: No Callbacks on FATAL
Date
Msg-id CAJ7c6TMYwE-oVLh3DZWroj-XdSKOooGx=GKuW4MkR3iO6pL7Vg@mail.gmail.com
Whole thread Raw
In response to Re: No Callbacks on FATAL  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: No Callbacks on FATAL
List pgsql-hackers
Hi hackers,

> > Hm? MemoryContextDelete() unconditionally calls the
> > callbacks. ShutdownPostgres() calls AbortOutOfAnyTransaction(). So if there's
> > an ongoing transaction, we'll call the reset callbacks on TopMemoryContext and
> > its children.
>
> Hmm ... I'd forgotten that we'd reach AbortOutOfAnyTransaction in
> the FATAL code path.  It does seem like any memory contexts below
> TopTransactionContext ought to get cleaned up then.

I wonder if this is a desired behavior. FATAL means a critical error
local to a given backend, but not affecting shared memory, right? Is
it generally safe to execute context memory callbacks having a FATAL
error?

> As you say, we really need more details to see what's happening here.

Yep, minimal steps to reproduce the issue would be much appreciated!

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: PG11 to PG14 Migration Slowness
Next
From: "houzj.fnst@fujitsu.com"
Date:
Subject: BF animal malleefowl reported an failure in 001_password.pl