Re: [PATCH] Remove unused #include's in src/backend/commands/* - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Remove unused #include's in src/backend/commands/*
Date
Msg-id CAJ7c6TO5cRvaLjNj4hdf8i+rSc27+7pDcLRtan4BQSE3wvr=Fw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Remove unused #include's in src/backend/commands/*  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] Remove unused #include's in src/backend/commands/*
List pgsql-hackers
Hi Andres,

> Manually analyze each of the removed includes by hand. Fix all the issues that
> lead to iwyu giving you wrong suggestions.

Well, I did, and played it as safe as I could in fact. Unfortunately
given the amount of (build systems * supported hardware * supported
operating systems * OS versions * build flags * #ifdefs in the code *
compilers) this is a difficult problem to reason about, for both
people and IWYU.

> Test it with CI in your own repo.

I see your point. I thought I tested the patch good enough locally to
make it pass on cfbot the first time, but clearly I was wrong. If
cfbot will complain again I'll continue experimenting with the patch
in my own repository.

Thanks for your feedback and apologies for the noise on the mailing
list. It was not intended.

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Álvaro Herrera
Date:
Subject: Re: [PATCH] Remove unused #include's in src/backend/commands/*
Next
From: Chao Li
Date:
Subject: Re: Add downloaded files to gitignore