Hi Junwang,
> PQputCopyEnd returns 1 or -1, never 0, I guess the comment was
> copy/paste from PQputCopyData's comment, this should be fixed.
The patch LGTM but I wonder whether we should also change all the
existing calls of PQputCopyEnd() from:
```
PQputCopyEnd(...) <= 0
```
... to:
```
PQputCopyEnd(...) < 0
```
Given the circumstances, checking for equality to zero seems to be at
least strange.
On top of that, none of the PQputCopyData() callers cares whether the
function returns 0 or -1, both are treated the same way. I suspect the
function does some extra work no one asked to do and no one cares
about. Perhaps this function should be refactored too for consistency.
Thoughts?
--
Best regards,
Aleksander Alekseev
