Request a Demo
Home   >   mailing lists

Re: [PATCH] Remove unused #include's in src/backend/commands/* - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: [PATCH] Remove unused #include's in src/backend/commands/*
Date
Msg-id CAJ7c6TP_aD+HhH84SHu-cb_39qYtpyDQ7jQ7Dz4KAB-tPs7rWw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Remove unused #include's in src/backend/commands/*  (Andres Freund <andres@anarazel.de>)
Responses Re: [PATCH] Remove unused #include's in src/backend/commands/*
List pgsql-hackers
Tree view 
Hi,

> > Why not use IWYU as recommended in src/tools/pginclude/README?  I gave that
> > a try and it didn't take very long for src/.
>
> I've not rechecked today, but the last time I did, iwyu needed a lot of adult
> supervision with the current amount of annotations. If we did all the
> necessary annotations and caught up with all the things it suggests it should
> be easier, but as-is it's imo just usable as an idea-giver for manually
> written patches.

OK, I tried include-what-you-use with a little post-processing script
and the scope of work seems reasonable. I will submit the updated
patch shortly.

-- 
Best regards,
Aleksander Alekseev

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Logical Replication of sequences
Next
From: Shayon Mukherjee
Date:
Subject: Re: [PATCH] Proposal: Allow reads to proceed during FK/trigger drops by reducing relation-level lock from AccessExclusive to ShareRowExclusive