Re: POC: Extension for adding distributed tracing - pg_tracing - Mailing list pgsql-hackers

From Aleksander Alekseev
Subject Re: POC: Extension for adding distributed tracing - pg_tracing
Date
Msg-id CAJ7c6TPgfrXjK3iu1Q2bg7uZ5=k5rQsuhORGbnUE1Eqt+cOfqw@mail.gmail.com
Whole thread Raw
In response to POC: Extension for adding distributed tracing - pg_tracing  (Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>)
Responses Re: POC: Extension for adding distributed tracing - pg_tracing
List pgsql-hackers
Hi Anthonin,

> I have a working prototype of a pg_tracing extension and wanted some feedback on the design and architecture.

The patch looks very interesting, thanks for working on it and for
sharing. The facts that the patch doesn't change the core except for
two lines in instrument.{c.h} and that is uses pull-based model:

> - Collect the spans through a new pg_tracing_spans() function output

... IMO were the right design decisions. The patch lacks the
documentation, but this is OK for a PoC.

I added the patch to the nearest CF [1]. Let's see what the rest of
the community thinks.

[1] https://commitfest.postgresql.org/44/4456/

-- 
Best regards,
Aleksander Alekseev



pgsql-hackers by date:

Previous
From: Anthonin Bonnefoy
Date:
Subject: POC: Extension for adding distributed tracing - pg_tracing
Next
From: Amit Kapila
Date:
Subject: Re: logical decoding and replication of sequences, take 2