Postgres Pro
Downloads
Home   >   mailing lists

Backwards boolean logic? - Mailing list pgsql-bugs

From Derek Viljoen
Subject Backwards boolean logic?
Date
Msg-id CAJVskpVMpF4hzFW+ORwV_YSrUa6d=i=E3pUAv6mjpNNhqL4SVQ@mail.gmail.com
Whole thread Raw
Responses Re: Backwards boolean logic?
List pgsql-bugs
Tree view
In hba.c in check_hba() function:


            /* Check SSL state */
            if (port->ssl_in_use)
            {
                /* Connection is SSL, match both "host" and "hostssl" */
                if (hba->conntype == ctHostNoSSL)
                    continue;
            }
            else
            {
                /* Connection is not SSL, match both "host" and "hostnossl" */
                if (hba->conntype == ctHostSSL)
                    continue;
            }

It looks to me like conntype should be reversed in this code block.

If that is not correct, then the comments should be updated to reflect the code.

pgsql-bugs by date:

Previous
From: PG Bug reporting form
Date:
Subject: BUG #15704: Possible causes for calling abort () system call during querying database.
Next
From: Jeff Janes
Date:
Subject: Re: BUG #15704: Possible causes for calling abort () system callduring querying database.