Re: Synchronizing slots from primary to standby - Mailing list pgsql-hackers

From shveta malik
Subject Re: Synchronizing slots from primary to standby
Date
Msg-id CAJpy0uCY+1eKs1W_1LUgG=sSoqTU6pVRyHmyfRsxPatE6QysdQ@mail.gmail.com
Whole thread Raw
In response to Re: Synchronizing slots from primary to standby  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Thu, Jan 25, 2024 at 9:13 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> > 3) Removed syncing 'failover' on standby from remote_slot. The
> > 'failover' field will be false for synced slots. Since we do not
> > support sync to cascading standbys yet, thus failover=true was
> > misleading and unused there.
> >
>
> But what will happen after the standby is promoted? After promotion,
> ideally, it should have failover enabled, so that the slots can be
> synced. Also, note that corresponding subscriptions still have the
> failover flag enabled. I think we should copy the 'failover' option
> for the synced slots.

Yes, right, missed this point earlier. I will make the change in the
next version.

thanks
Shveta



pgsql-hackers by date:

Previous
From: Richard Guo
Date:
Subject: A compiling warning in jsonb_populate_record_valid
Next
From: Amit Langote
Date:
Subject: Re: A compiling warning in jsonb_populate_record_valid