Re: How can end users know the cause of LR slot sync delays? - Mailing list pgsql-hackers

On Thu, Nov 27, 2025 at 9:25 AM Shlok Kyal <shlok.kyal.oss@gmail.com> wrote:
>
> I have made some minor changes in documentation and comments. Attached
> the updated patch.
>

1)
<literal>NULL</literal> if
       slot synchronization is successful.

We shall add 'It is' to maintain continuity as the previous sentence has it.

2)
Related to previous patch: pgstat_report_replslotsync() currently has
sanity check Assert(SlotIsLogical(slot));
Instead, shall we have Assert(slot->synced)? It will implicitly ensure
that the slot is logical, plus it is important to check that we are
updating stats of synced slot only.

thanks
Shveta