On Tue, Oct 17, 2017 at 1:07 AM, Dave Page <dpage@pgadmin.org> wrote:
I can see why for some people who choose to turn auto-commit/auto-rollback off they may be useful, however we cannot simply add new features every time someone asks for something. Doing so adds maintenance costs, and increases complexity of the UI for *everyone*. That is part of the reason why pgAdmin III became unmaintainable; we added too many features on a whim without giving enough thought to whether or not the added code and UI complexity was justified, and eventually ended up with a mess of spaghetti-code.
So consider the lack of requests to be not so lacking anymore...
One concrete advantage to the buttons, and mind you I haven't actually used pgAdmin4 but do use a GUI, is that in my GUI if you were to send the COMMIT command to the server as text any and all result set tables that are present on the current screen are removed the a new command result for the commit response replaces them. If one uses the button the result tables are left alone.
Frankly, auto-commit mode can be dangerous so if you are advocating that people simply use that and forget about manually committing altogether I think you are misguided in your thinking. In the UI that I use if I send a "begin" to the server then, and only then, do the commit/rollback buttons appear (and auto-commit is disabled temporarily). With that flow your "end-user UI complexity" argument becomes significantly more specious and you are just left with "code complexity".
