Re: [PATCH] Fix a tiny typo in the documentation - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: [PATCH] Fix a tiny typo in the documentation
Date
Msg-id CAKFQuwYoGK8bZfztb0mw3QdukbDjQqQu4gPsPn3-9BZ5BUz8Bw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Fix a tiny typo in the documentation  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: [PATCH] Fix a tiny typo in the documentation
List pgsql-hackers
On Wednesday, January 22, 2025, Daniel Gustafsson <daniel@yesql.se> wrote:
> On 22 Jan 2025, at 11:23, Daniel Gustafsson <daniel@yesql.se> wrote:
>> On 22 Jan 2025, at 09:27, Robin Dupret <robin.dupret@gmail.com> wrote:

>> -    special provision: you must write
>> +    special provision you must write:
>
> Nice catch, will fix.

Re-reading it I think both placements of ':' are grammatically correct (not
being a native speaker might trick me).  The current one is, I'm sure,
intentional but I agree it looks a bit odd to continue the sentence into a
<programlisting> block and ending it without punctuation.  For now I'm inclined
to leave it though.


The colon does belong after provision, not write.  If the colon is bothersome rewrite to avoid it altogether.  But the status quo works for me.

David J.
 

pgsql-hackers by date:

Previous
From: Japin Li
Date:
Subject: Re: [RFC] Lock-free XLog Reservation from WAL
Next
From: Peter Eisentraut
Date:
Subject: Re: Pgoutput not capturing the generated columns