Re: Stability of queryid in minor versions - Mailing list pgsql-hackers

From David G. Johnston
Subject Re: Stability of queryid in minor versions
Date
Msg-id CAKFQuwaPQ6g-ea8L+Pcz2TjCaSaBSOkLWj=+kXKs=-z+JuAowA@mail.gmail.com
Whole thread Raw
In response to Re: Stability of queryid in minor versions  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Sun, Apr 14, 2024 at 7:03 PM David Rowley <dgrowleyml@gmail.com> wrote:
On Mon, 15 Apr 2024 at 13:37, David G. Johnston
<david.g.johnston@gmail.com> wrote:
> Seems we can improve things by simply removing the "rule of thumb" sentence altogether.  The prior paragraph states the things the queryid depends upon at the level of detail the reader needs.

I don't think that addresses the following, which I mentioned earlier:

> but not stable across *major* versions does *not* mean stable across
> *minor* versions. The reader is just left guessing if that's true.


The base assumption here is that changes in the things we don't mention do not influence the queryid.  We didn't mention minor versions, changing them doesn't influence the queryid.

Now, reading that entire paragraph is a bit of a challenge IMO, and agree, as I subsequently noted, that the sentence you pointed out could be reworked.  I stand by my statement that removing the sentence about "rule of thumb" altogether is a win.  The prior paragraph should be sufficient - it is technically at the moment but am not opposed to rewording.

David J.

pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Fix out-of-bounds in the function GetCommandTagName
Next
From: David Rowley
Date:
Subject: Re: Stability of queryid in minor versions