Re: [PATCH] Tables node (pgAdmin4) - Mailing list pgadmin-hackers
Hi,
PFA patch for RM#1231 & RM#1237.
Additionally I have shifted 'Advanced tab' after columns & constraint tab.
@Thom,
Reading "Of type" drop-down, We borrowed sql query from pgadmin3 to populate "Of type" combo box as given below.
I was not able to find a way to differentiate between table & composite type populating from below given query,
I'll put in todo list, may be someone from community can help in future.
SELECT t.oid,
quote_ident(n.nspname)||'.'||quote_ident(t.typname) AS typname
FROM pg_type t, pg_namespace n
WHERE t.typtype='c' AND t.typnamespace=n.oid
AND NOT (n.nspname like 'pg_%' OR n.nspname='information_schema')
ORDER BY typname;
Regards,
Murtuza
On 25-May-2016, at 9:34 pm, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Thanks.
On May 25, 2016 21:01, "Thom Brown" <thom@linux.com> wrote:Thanks. I've raised all of these in tickets 1231 to 1237.ThomOn 25 May 2016 at 04:23, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:Hi Thom,Can you please create RM cases for the same, it will be easy to track those issues?We're using "https://redmine.postgresql.org/projects/pgadmin4/" for the same.On Wed, May 25, 2016 at 6:42 AM, Thom Brown <thom@linux.com> wrote:Last issue today:On 25 May 2016 at 02:00, Thom Brown <thom@linux.com> wrote:
> On 25 May 2016 at 00:29, Thom Brown <thom@linux.com> wrote:
>> On 24 May 2016 at 19:09, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
>>>
>>> On Mon, May 23, 2016 at 6:35 PM, Murtuza Zabuawala
>>> <murtuza.zabuawala@enterprisedb.com> wrote:
>>>>
>>>> Hi,
>>>>
>>>> PFA patch, which will fixes below mentioned issues,
>>>
>>> Committed.
>>
>>
>> In the Create Table dialog, on the Advanced tab, the "Of type" drop-down
>> lists tables and composite types, but those are supposed to just be
>> composite types.
>>
>> Also, when using OF in CREATE TABLE, LIKE is no longer valid, so LIKE should
>> be disabled when using OF. Also, there should probably be a way of setting
>> options for the columns taken from the composite type. For example:
>>
>> CREATE TYPE inventory AS (product_id bigint, product_name text, weight
>> numeric);
>>
>> CREATE TABLE stock OF inventory (
>> PRIMARY KEY (product_id),
>> weight WITH OPTIONS DEFAULT 0
>> );
>>
>> There's currently no way of doing this (neither the primary key, nor the
>> default value for any columns). It should probably automatically populate
>> the columns from the composite type on the columns tab.
>>
>> Also, could the generated SQL have an empty line between each statement?
>
> Another thing I've noticed is that, when adding columns, the "Is
> primary key?" column is greyed out. Why not just make those
> modifiable in that view rather than having to go into the details for
> each column?
>
> When there's something that hasn't been set up correctly, like adding
> variables for a column, but not actually selecting a variable, the SQL
> pane, correctly, doesn't show an output, but the error message,
> "Please provide input for variable." isn't enough to identify what
> needs checking. Could the relevant tab and field/row be
> highlighted/coloured in red/bold? This is more general, so doesn't
> just apply to the create table dialog.
When using "Of type", it's not valid to allow additional columns to be
added, so those should be prevented.
Thom
Attachment
pgadmin-hackers by date: