Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement - Mailing list pgsql-hackers

From Manni Wood
Subject Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement
Date
Msg-id CAKWEB6obc_SB5Xj7NCMFQOoAeVX9LD8EvkvbtZXP9XTSe4OEiQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement  (Nishant Sharma <nishant.sharma@enterprisedb.com>)
Responses Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement
List pgsql-hackers


On Wed, Nov 5, 2025 at 5:54 AM Nishant Sharma <nishant.sharma@enterprisedb.com> wrote:
Thanks Álvaro for the review comments on v4!

PFA, v5 patch set. I have included all your review comments. 


Regards,
Nishant Sharma.
EDB, Pune.

The BSD build was failing with the error 'WARNING:  tablespaces created by regression test cases should have names starting with "regress_"', so the attached patches should fix that.

The windows build is also failing, on this error "../src/port/strerror.c(311): fatal error C1051: program database file, 'C:\cirrus\build\src\port\libpgport_srv.pdb', has an obsolete format, delete it and recompile", which I don't think is related to our patch.
--
-- Manni Wood EDB: https://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Tuesday at 2026.pgconf.dev
Next
From: Michael Paquier
Date:
Subject: Re: [Patch] Windows relation extension failure at 2GB and 4GB