Request a Demo
Home   >   mailing lists

Re: Non-text mode for pg_dumpall - Mailing list pgsql-hackers

From Mahendra Singh Thalor
Subject Re: Non-text mode for pg_dumpall
Date
Msg-id CAKYtNAo-6HZy-JhTYS321AxGE_BPCg7WTFVLeXTuFMZ6HYK2vg@mail.gmail.com
Whole thread Raw
In response to Re: Non-text mode for pg_dumpall  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Responses Re: Non-text mode for pg_dumpall
List pgsql-hackers
Tree view
Thanks Alvaro for quick feedback.

On Sat, 11 Jan 2025 at 2:14 PM, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
Hmm, this patch adds a function connectDatabase() to pg_restore, but a
function that's almost identical already exists in pg_dumpall.  

Yes, you are right. Both functions are same as I copied this function from pg_dumpall.c.


suggest they should be unified.  Maybe create a new file for connection
management routines? (since this clearly doesn't fit common.c nor
dumputils.c).

Sure. I will create a new file and I will move these common functions into that.

Thanks and regards
Mahendra Singh Thalor
 


--
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"In Europe they call me Niklaus Wirth; in the US they call me Nickel's worth.
 That's because in Europe they call me by name, and in the US by value!"

pgsql-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: explain analyze rows=%.0f
Next
From: Sami Imseih
Date:
Subject: Re: why there is not VACUUM FULL CONCURRENTLY?