On Wed, 12 Feb 2025 at 00:11, Matheus Alcantara
<matheusssilv97@gmail.com> wrote:
>
> Hi,
>
> Em ter., 11 de fev. de 2025 às 03:39, jian he
> <jian.universality@gmail.com> escreveu:
> > hi. some minor issue i found.
> >
> > +#include "storage/block.h"
> > no need, since "#include "storage/bufmgr.h" already included it.
> >
> Fixed
>
> > do we need to add ``CHECK_FOR_INTERRUPTS()`` in heapam_read_stream_next_block?
> >
> The current code on master don't CHECK_FOR_INTERRUPTS, so I would prefer to not
> change this behaviour, but I think that is considerable.
>
> > heapam_read_stream_next_block_private need add to
> > src/tools/pgindent/typedefs.list
> >
> Fixed
>
> > overall, it looks good to me.
>
> Thanks for the review! v3 with the fixes attached.
I noticed that Nazir Bilal Yavuz's comment from [1] is not yet
addressed, i have changed the status of commitfest entry to Waiting on
Author, please address them and update it to Needs review.
[1] - https://www.postgresql.org/message-id/CAN55FZ2CGxcqTk_LLRPAi2aFNqtR4o=JPfjN0=yT0yObfQ2h2g@mail.gmail.com
Regards,
Vignesh
