On Wed, 8 Oct 2025 at 15:38, Dilip Kumar <dilipbalaut@gmail.com> wrote:
>
> On Wed, 8 Oct 2025 at 3:15 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>> On Wed, Oct 8, 2025 at 2:41 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
>> >
>> > On Tue, Oct 7, 2025 at 4:52 PM vignesh C <vignesh21@gmail.com> wrote:
>> > >
>> > > On Tue, 7 Oct 2025 at 12:09, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> > > >
>> >
>> > I think the patch is mostly LGTM, I have 2 suggestions, see if you
>> > think this is useful.
>> >
>> > 1.
>> > postgres[1390699]=# CREATE PUBLICATION pub FOR ALL SEQUENCES, ALL
>> > TABLES WITH (publish = insert);
>> > NOTICE: 55000: publication parameters are not applicable to sequence
>> > synchronization and will be ignored
>> > LOCATION: CreatePublication, publicationcmds.c:905
>> >
>> > IMHO this notice seems confusing, from this it appears that (publish =
>> > insert) is ignored completely, but actually it is is not ignored for
>> > table, should we explicitely say that it will be ignored only for
>> > sequences. Something like below?
>> >
>> > "publication parameters are not applicable to sequence synchronization
>> > so it will be used only for tables and will be ignored for sequence
>> > synchronization"
>> > or
>> > "publication parameters are not applicable to sequence synchronization
>> > so it will be ignored for the sequence synchronization"
>> >
>>
>> How about a slightly shorter form like: 'publication parameters are
>> not applicable to sequence synchronization and will be ignored for
>> sequences'?
>
> Works for me.
Thanks for the comments, here is an updated version with a fix to handle this.
Regards,
Vignesh
