Re: Fortify float4 and float8 regression tests by ordering test results - Mailing list pgsql-hackers

From Pavel Borisov
Subject Re: Fortify float4 and float8 regression tests by ordering test results
Date
Msg-id CALT9ZEGcRK3nCvg01CoK74Tk2Ua1kHBC52K0nV2On_ELyncQhg@mail.gmail.com
Whole thread Raw
In response to Re: Fortify float4 and float8 regression tests by ordering test results  (Alexander Korotkov <aekorotkov@gmail.com>)
Responses Re: Fortify float4 and float8 regression tests by ordering test results
List pgsql-hackers
Hi!

On Tue, 22 Apr 2025 at 20:22, Alexander Korotkov <aekorotkov@gmail.com> wrote:
>
> On Tue, Apr 22, 2025 at 7:20 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > Alexander Korotkov <aekorotkov@gmail.com> writes:
> > > I'd like to add that float4.out not only assumes that insert-ordering is
> > > preserved (this could be more-or-less portable between table AMs).  It also
> > > assumes the way UPDATE moves updated rows.  That seems quite
> > > heap-specific.  You can see in the following fragment, updated rows jump to
> > > the bottom.
> >
> > I'd be willing to consider a policy that we don't want to depend on
> > exactly where UPDATE moves rows to.  The proposed patch is not that,
> > however.
>
> OK, that makes sense for me.

Thanks for this input!
This was my first intention to fix only the test that was affected by
UPDATE-order specifics, broke when runnung on an extension AM.
Maybe I was too liberal and added ORDER BY's more than needed.
I definitely agree to the proposal.

Please find attached v2 that fixes only UPDATE-specific part of
float4/float8 test.

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: What's our minimum supported Python version?
Next
From: Laurenz Albe
Date:
Subject: Re: Cygwin support