Re: Change comment in `contrib/amcheck` regression suite. - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: Change comment in `contrib/amcheck` regression suite.
Date
Msg-id CALdSSPhAcQBDDZSJUT74jNrt659tsFSFwkcdAssc_oQBJ6GJ7g@mail.gmail.com
Whole thread Raw
In response to Re: Change comment in `contrib/amcheck` regression suite.  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: Change comment in `contrib/amcheck` regression suite.
List pgsql-hackers
On Wed, 14 Jan 2026 at 11:06, Andreas Karlsson <andreas@proxel.se> wrote:
>
> On 12/6/25 12:53 PM, Kirill Reshke wrote:
> > I did find a misleading comment in amcheck's regression test suite,
> > during un-related hacking in Cloudberry[0]. There is a comment which
> > says `-- Check that sequences are rejected` but those are supported
> > starting c3b011d
> >
> > Lets make things not misleading.
>
> I think we should change a bit more to make it more like the tests for
> heap tables. What do you think?
>
> Andreas

Well, additional tests are good, but I did not get why cleanup is
needed (how it worked before?). We don't create anything new in your
patch, but for some reason need to drop..

-- 
Best regards,
Kirill Reshke



pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: [RFC] SLIM Data Type - Compact JSON Alternative (17-62% smaller)
Next
From: Anthonin Bonnefoy
Date:
Subject: Re: Stmt timeout error can be sent after a CommandComplete