Request a Demo
Home   >   mailing lists

Re: GIN pageinspect support for entry tree and posting tree - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: GIN pageinspect support for entry tree and posting tree
Date
Msg-id CALdSSPhcbAM8HdtfDHQVE=UNMoAH7-QmUGPKbAkxMTVk=3picg@mail.gmail.com
Whole thread Raw
In response to Re: GIN pageinspect support for entry tree and posting tree  (Kirill Reshke <reshkekirill@gmail.com>)
Responses Re: GIN pageinspect support for entry tree and posting tree
Re: GIN pageinspect support for entry tree and posting tree
List pgsql-hackers
Tree view 
On Thu, 8 Jan 2026 at 22:11, Kirill Reshke <reshkekirill@gmail.com> wrote:
>
> On Thu, 8 Jan 2026 at 21:49, Andrey Borodin <x4mmm@yandex-team.ru> wrote:
> > > On 8 Jan 2026, at 01:57, Kirill Reshke <reshkekirill@gmail.com> wrote:
> > >
> > > PFA v10
> >
> > Also it seems that you used something that is not pgindent.
>
> Why
>
> > Looks like clang-format with default settings.
>
> I use "./src/tools/pg_bsd_indent/pg_bsd_indent  -l79 -di12 -nfc1 -nlp
> -sac ./contrib/pageinspect/ginfuncs.c"
>
>
>
>
> --
> Best regards,
> Kirill Reshke

Okay, after off-list discussion looks like my options to pg_bsd_indent
are bad, better is:

"./src/tools/pg_bsd_indent/pg_bsd_indent -bad -bap -bbb -bc -bl -cli1
-cp33 -cdb -nce -d0 -di12 -nfc1 -i4 -l79 -lp -lpl -nip -npro -sac -tpg
-ts4 ./contrib/pageinspect/ginfuncs.c"

And still this is not OK to use plain pg_bsd_indent and thus I used
" ./src/tools/pgindent/pgindent ./contrib/pageinspect/ginfuncs.c"

v11 with this and commit message polishing

-- 
Best regards,
Kirill Reshke
Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Always show correct error message for statement timeouts, fixes random buildfarm failures
Next
From: Tom Lane
Date:
Subject: Re: improve performance of pg_dump with many sequences