Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row
Date
Msg-id CALdSSPhxprTyzzr4tk-QU-GUroBKYNuJJ2GxWnExbB=bjQjJ7w@mail.gmail.com
Whole thread Raw
In response to Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row  ("David G. Johnston" <david.g.johnston@gmail.com>)
List pgsql-hackers
On Fri, 10 Jan 2025 at 11:38, jian he <jian.universality@gmail.com> wrote:
> I think there are three remaining issues that may need more attention
> 1.
> Table 27.42. pg_stat_progress_copy View
> (<structname>pg_stat_progress_copy</structname>)
> column pg_stat_progress_copy.tuples_skipped now the description is
> ""
> When the ON_ERROR option is set to ignore, this value shows the number of tuples
> skipped due to malformed data. When the ON_ERROR option is set to set_to_null,
> this value shows the number of tuples where malformed data was converted to
> NULL.
> """
> now the column name tuples_skipped would not be that suitable for
> (on_error set_to_null).
> since now it is not tuple skipped, it is in a tuple some value was set to null.

Indeed this is something we need to fix.

> Or
> we can skip progress reports for (on_error set_to_null) case.

Maybe we can add a `malformed_tuples` column to this view?


> 3. do we settled (on_error set_to_null) syntax.

I think so. I prefer this syntax to others discussed in this thread.



-- 
Best regards,
Kirill Reshke



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Include patch id in commitfest page
Next
From: Guillaume Lelarge
Date:
Subject: Re: improve DEBUG1 logging of parallel workers for CREATE INDEX?