Request a Demo
Home   >   mailing lists

Re: Use IsA() macro instead of nodeTag comparison - Mailing list pgsql-hackers

From Kirill Reshke
Subject Re: Use IsA() macro instead of nodeTag comparison
Date
Msg-id CALdSSPi5fWXfby+B+rpT--zuazGhmBd3Bg1L3VGDCpabeRYGFw@mail.gmail.com
Whole thread Raw
In response to Use IsA() macro instead of nodeTag comparison  (Shinya Kato <shinya11.kato@gmail.com>)
Responses Re: Use IsA() macro instead of nodeTag comparison
List pgsql-hackers
Tree view 
On Thu, 8 Jan 2026 at 17:31, Shinya Kato <shinya11.kato@gmail.com> wrote:
>
> Hi hackers,

Hi

> In copy.c, nodeTag was being compared directly, so I replaced it with
> the IsA() predicate macro for consistency.

Oops. Looks like oversight in 6c8f670. This is indeed case where we
should use IsA()

> I verified that there are no other direct comparisons left by running
> the following command:
> $ git grep "nodeTag(.*) =="

Yep, look like this is the only case in copy.c

> --
> Best regards,
> Shinya Kato
> NTT OSS Center



-- 
Best regards,
Kirill Reshke

pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Re: Refactor replication origin state reset helpers
Next
From: Richard Guo
Date:
Subject: Re: Fwd: pg18 bug? SELECT query doesn't work