Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM
Date
Msg-id CALj2ACWRfR-gRpno5eE1oo8twC4sfode0odsh2_DStNtM-YvHw@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM  (vignesh C <vignesh21@gmail.com>)
Responses Re: [PATCH] Remove Extra palloc Of raw_buf For Binary Format In COPY FROM
List pgsql-hackers
Tree view 
Thanks Rushabh and Vignesh for the comments.

>
> One comment:
> We could change below code:
> + */
> + if (!cstate->binary)
> + cstate->raw_buf = (char *) palloc(RAW_BUF_SIZE + 1);
> + else
> + cstate->raw_buf = NULL;
> to:
> cstate->raw_buf = (cstate->binary) ? NULL : (char *) palloc(RAW_BUF_SIZE + 1);
>

Attached the patch with the above changes.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
Attachment

pgsql-hackers by date:

Previous
From: "David G. Johnston"
Date:
Subject: Re: [PATCH] postgres_fdw connection caching - cause remote sessionslinger till the local session exit
Next
From: Masahiko Sawada
Date:
Subject: Re: xid wraparound danger due to INDEX_CLEANUP false