Re: Improve GetConfigOptionValues function - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: Improve GetConfigOptionValues function
Date
Msg-id CALj2ACXZMOGEtjk+eh0Zeiz=46ETVkr0koYAjWt8SoJUJJUe9g@mail.gmail.com
Whole thread Raw
In response to Re: Improve GetConfigOptionValues function  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Wed, Jan 18, 2023 at 9:44 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Possibly a better answer is to refactor into separate functions,
> along the lines of
>
> static bool
> ConfigOptionIsShowable(struct config_generic *conf)
>
> static void
> GetConfigOptionValues(struct config_generic *conf, const char **values)

+1 and ConfigOptionIsShowable() function can replace explicit showable
checks in two other places too.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: [PATCH] Tracking statements entry timestamp in pg_stat_statements
Next
From: Vik Fearing
Date:
Subject: Re: ANY_VALUE aggregate