Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: [FileManager] ReferenceError: assignment to undeclared variable t_res - Mailing list pgadmin-hackers

From Surinder Kumar
Subject Re: [pgAdmin4][Patch]: [FileManager] ReferenceError: assignment to undeclared variable t_res
Date
Msg-id CAM5-9D9rdiyQC6Wg4Kby3wZc6p6hOt8++cBvPC1j7oLtmFibcA@mail.gmail.com
Whole thread Raw
In response to Re: [pgAdmin4][Patch]: [FileManager] ReferenceError: assignment to undeclared variable t_res  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: [FileManager] ReferenceError: assignment to undeclared variable t_res
List pgadmin-hackers
Tree view


On Tue, May 24, 2016 at 1:35 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:
On Tue, May 24, 2016 at 1:34 PM, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Tue, May 24, 2016 at 12:35 PM, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi

Issues fixed:
1. ReferenceError: assignment to undeclared variable t_res in FileManager
2. Add missing default case in switch statement.
3. code improvements.
 
What are those, can you please *share* some insight?
1. Added curly braces for If statements.
2. Removed unnecessary code which was setting dialog_title twice.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company



issue #1 is reproduced on mozilla browser of ubuntu machine when FileManager is opened for the first time in Backup server tool.
Thanks to Neel for reporting the issue #1.

Please review the patch.

Thanks,
Surinder Kumar


 --
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: [pgAdmin4][Patch]: [FileManager] ReferenceError: assignment to undeclared variable t_res
Next
From: Surinder Kumar
Date:
Subject: [pgAdmin4][Patch]: Add support for CREATE, SELECT & INSERT functionality in View and Materialized view