Postgres Pro
Downloads
Home   >   mailing lists

Re: [HACKERS] pow support for pgbench - Mailing list pgsql-hackers

From Raúl Marín Rodríguez
Subject Re: [HACKERS] pow support for pgbench
Date
Msg-id CAM6_UM41nbU4oPcQ72AM0gEf7OtvasrKbSUeb2VnEN8FVUc8wg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] pow support for pgbench  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [HACKERS] pow support for pgbench
Re: [HACKERS] pow support for pgbench
List pgsql-hackers
Tree view
Hi,

Please add the new function into the documentation table in alphabetical order.
Fixed in the attached patch.

 What's the name of the backend function whose behavior this matches?
As Fabien has mentioned, it tries to behave as "numeric_power". Maybe we it'd
better if we switch to "dpow" (which is pow with some error handling) and always
return a double. What do you think?

On Fri, Dec 1, 2017 at 8:02 PM, Robert Haas <robertmhaas@gmail.com> wrote:
On Fri, Dec 1, 2017 at 4:57 AM, Raúl Marín Rodríguez
<rmrodriguez@carto.com> wrote:
> I've rebased the patch so it can be applied cleanly on top of current
> master.

Please add the new function into the documentation table in alphabetical order.

The fact that the return type is not consistently of one type bothers
me.  I'm not sure pgbench's expression language is a good place to
runtime polymorphism -- SQL doesn't work that way.

+ /*
+  * pow() for integer values with exp >= 0. Matches SQL pow() behaviour
+  */

What's the name of the backend function whose behavior this matches?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Raúl Marín Rodríguez 
carto.com

Attachment

pgsql-hackers by date:

Previous
From: John Naylor
Date:
Subject: WIP: a way forward on bootstrap data
Next
From: Justin Pryzby
Date:
Subject: Re: Doc tweak for huge_pages?